[Openmp-commits] [PATCH] D89426: [libomptarget] Require LLVM source tree to build libomptarget

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

`set(LLVM_MAIN_INCLUDE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/../llvm/include)` is interesting.

I'm not sure it's reasonable for openmp to guess at a plausible definition for LLVM_MAIN_INCLUDE_DIR and overwrite it. That composes poorly with (possibly imaginary) cmake that do their own testing based on this variable.

How about we introduce a whole new one,
`LIBOMPTARGET_LLVM_MAIN_INCLUDE_DIR`,
which is set to LLVM_MAIN_INCLUDE_DIR if available, otherwise to that guess, otherwise skip libomptarget?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89426/new/

https://reviews.llvm.org/D89426