[Openmp-commits] [PATCH] D89426: [libomptarget] Require LLVM source tree to build libomptarget

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added a comment.

ENABLE_LIBOMPTARGET determines the initial default value for OPENMP_ENABLE_LIBOMPTARGET. Therefore the variable is only relevant in the first cmake run, but has no effect in successive cmake or ccmake configures. It will never overwrite the value of OPENMP_ENABLE_LIBOMPTARGET.

I'm not sure, whether the mono-repo structure is considered somewhere to find  LLVM_MAIN_INCLUDE_DIR, but we should set the variable here to allow building openmp stand-alone in a mono-repo clone.



================
Comment at: openmp/CMakeLists.txt:69-72
+if (NOT LLVM_MAIN_INCLUDE_DIR)
+  message(STATUS "Missing definition for LLVM_MAIN_INCLUDE_DIR, disabling libomptarget")
+  set(ENABLE_LIBOMPTARGET OFF)
+endif()
----------------
This change would allow to build openmp (with libomptarget) standalone, while checked out as mono-repo:



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89426/new/

https://reviews.llvm.org/D89426