[Openmp-commits] [PATCH] D91713: [libomptarget] Implement get_device_num for amdgcn, nvptx

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 accepted this revision.
tianshilei1992 added a comment.
This revision is now accepted and ready to land.

Overall LGTM.



================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:83
 /// Manually sync with the deviceRTL side for now, move to a dedicated header
 /// file later.
 struct omptarget_device_environmentTy {
----------------
JonChesterfield wrote:
> We have a dedicated header now, in "../../../deviceRTLs/common/device_environment.h".
> 
> Options:
> 1/ keep the copy & paste, plugins & deviceRTL are totally separate
> 2/ Include from the deviceRTL
> 3/ Move header to somewhere else, openmp/libomptarget/include looks reasonable
> 
> 
Option 3 sounds more reasonable. We might have data structures used by both device and host runtime.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91713/new/

https://reviews.llvm.org/D91713