[Openmp-commits] [PATCH] D91713: [libomptarget] Implement get_device_num for amdgcn, nvptx

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/plugins/amdgpu/src/rtl.cpp:530
 
-// TODO: May need to drop the trailing to fields until deviceRTL is updated
+/// Device environment data
+/// Manually sync with the deviceRTL side for now, move to a dedicated header
----------------
I forgot to remove the extra fields from this to match the deviceRTL in trunk when adding amdgpu/src/rtl.cpp. This brings them back in sync.


================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:83
 /// Manually sync with the deviceRTL side for now, move to a dedicated header
 /// file later.
 struct omptarget_device_environmentTy {
----------------
We have a dedicated header now, in "../../../deviceRTLs/common/device_environment.h".

Options:
1/ keep the copy & paste, plugins & deviceRTL are totally separate
2/ Include from the deviceRTL
3/ Move header to somewhere else, openmp/libomptarget/include looks reasonable




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91713/new/

https://reviews.llvm.org/D91713