[Openmp-commits] [PATCH] D89898: changing OMP rtl to use shared memory instead of env variable

[Roger Ferrer Ibanez via Phabricator via Openmp-commits]

rogfer01 added a comment.

Hi @jdoerfert

> [Drive by] What about appending the process id or a random number to the file name, or both?

yeah, the patch already does this. The space of PIDs it is not too large (most systems still use 16-bit PIDs) so collisions are not that unlikely. It is just a bit confusing that an OpenMP application fails due to this, sporadically, at startup.

Perhaps the scenario of leftover files is not that common: probably only if the process receives a `SIGKILL`. Most scheduling systems will send `SIGTERM` first and users often use `SIGINT` or `SIGQUIT`.

Kind regards,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89898/new/

https://reviews.llvm.org/D89898