[Openmp-commits] [PATCH] D89898: changing OMP rtl to use shared memory instead of env variable

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

In D89898#2400384 <https://reviews.llvm.org/D89898#2400384>, @rogfer01 wrote:

> I wonder if due to abnormal termination of the process some files might not have a chance to be removed? In that case I understand that the `0666` in `shm_open(..., O_CREAT, ...)` will still honour `umask` (commonly it is `0022` so the files are created with `rw-r--r--`). Was the intent of this change to create a `rw-rw-rw-` file instead? That would avoid the `EACCES`, in case another user hits the same file because it wasn't removed. Not sure if this is the intended behaviour here.

[Drive by] What about appending the process id or a random number to the file name, or both?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89898/new/

https://reviews.llvm.org/D89898