[Openmp-commits] [PATCH] D82245: [libomptarget] Add support for target update non-contiguous

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:638
 
+static int target_data_contiguous(DeviceTy &Device, void *args_base, void *args,
+                                  int64_t arg_size, int64_t arg_type) {
----------------
tianshilei1992 wrote:
> Based on LLVM standard, this function should be
> ```
> static int targetDataContiguous(DeviceTy &Device, void *ArgsBase, void *Arg, int64_t argSize, int64_t ArgType)
> ```
```
static int targetDataContiguous(DeviceTy &Device, void *ArgsBase, void *Arg, int64_t ArgSize, int64_t ArgType)
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82245/new/

https://reviews.llvm.org/D82245