[Openmp-commits] [PATCH] D82245: [libomptarget] Add support for target update non-contiguous

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Nov 10 12:05:46 PST 2020

tianshilei1992 added a comment.

In D82245#2386727 <https://reviews.llvm.org/D82245#2386727>, @cchen wrote:

> In D82245#2386544 <https://reviews.llvm.org/D82245#2386544>, @tianshilei1992 wrote:
>> In D82245#2383337 <https://reviews.llvm.org/D82245#2383337>, @cchen wrote:
>>> Fix coding style
>> I'm not sure whether this is still WIP because I didn't see any change in the touched code.
> I've changed the name of the argument in that function and apply clang-format on the function. Is there any place that I'm not following the coding style? I'm just waiting for acceptance to merge the patch.

Take the inline comment as an example, but for those C functions, just leave them what they're now.

Comment at: openmp/libomptarget/src/omptarget.cpp:638
+static int target_data_contiguous(DeviceTy &Device, void *args_base, void *args,
+                                  int64_t arg_size, int64_t arg_type) {
Based on LLVM standard, this function should be
static int targetDataContiguous(DeviceTy &Device, void *ArgsBase, void *Arg, int64_t argSize, int64_t ArgType)

  rG LLVM Github Monorepo



More information about the Openmp-commits mailing list