[Openmp-commits] [PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added a comment.

In D80222#2060420 <https://reviews.llvm.org/D80222#2060420>, @jdoerfert wrote:

> Take a look at D80735 <https://reviews.llvm.org/D80735>, it works fine for me locally. Is that what you did? What problems do you observe now?


That's pretty much what I did. If I kept in the old Ident declaration, but didn't use it and returned `llvm::omp::types::IdentPtr` from that function it would work. But the compiler would segfault if I removed it. It still failed the two problematic tests. I have a patch that changes the function to return a FunctionCallee and does a bitcast on the function if the types don't match. That passed the tests but it would be beneficial if we could get it to work without needing to change it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80222/new/

https://reviews.llvm.org/D80222