[Openmp-commits] [PATCH] D79702: [OpenMP] Fix race condition in the completion/freeing of detached tasks

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim marked an inline comment as done.
protze.joachim added inline comments.


================
Comment at: openmp/runtime/src/kmp_tasking.cpp:900
       // event hasn't been fulfilled yet. Try to detach task.
-      __kmp_acquire_tas_lock(&taskdata->td_allow_completion_event.lock, gtid);
+      auto competion_lock = &taskdata->td_allow_completion_event.lock;
+      __kmp_acquire_tas_lock(competion_lock, gtid);
----------------
AndreyChurbanov wrote:
> completion_lock looks a better name than competion_lock (typo?).
I revert this change to use a temporal variable (not sure whether use of auto is accepted in general). With the locking in kmp_fulfill_event this is not needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79702/new/

https://reviews.llvm.org/D79702