[Openmp-commits] [PATCH] D76843: [Openmp] Libomptarget plugin for NEC SX-Aurora

[Simon Moll via Phabricator via Openmp-commits]

simoll added inline comments.


================
Comment at: openmp/libomptarget/plugins/ve/src/rtl.cpp:25
+#include <vector>
+#include <veosinfo/veosinfo.h>
+
----------------
Missing `#include <algorithm>` for the `std::sort` below.


================
Comment at: openmp/libomptarget/plugins/ve/src/rtl.cpp:369
+  if (ret != 0) {
+    DP("veo_alloc_mem(%d, %p, %" PRIu64 ") failed with error code %" PRIu64
+       "\n",
----------------
Use `%d` instead of `PRIu64` for the `int ret`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76843/new/

https://reviews.llvm.org/D76843