[Openmp-commits] [PATCH] D76551: [Alignment][NFC] Use TargetFrameLowering::getStackAlign()

[Guillaume Chatelet via Phabricator via Openmp-commits]

gchatelet updated this revision to Diff 251969.
gchatelet marked 3 inline comments as done.
gchatelet added a comment.
Herald added subscribers: libc-commits, openmp-commits, libcxx-commits, cfe-commits, Joonsoo, kerbowa, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, csigg, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini, dmgreen, rupprecht, arphaman, dexonsmith, steven_wu, mgorny, nhaehnle, jvesely, emaste, jholewinski.
Herald added a reviewer: bollu.
Herald added a reviewer: espindola.
Herald added a reviewer: alexshap.
Herald added a reviewer: jhenderson.
Herald added a reviewer: nicolasvasilache.
Herald added a reviewer: herhut.
Herald added a reviewer: rriddle.
Herald added a reviewer: aartbik.
Herald added projects: clang, libc++, OpenMP, libc-project.
Herald added a reviewer: libc++.

- inline variable
- Address comments


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76551/new/

https://reviews.llvm.org/D76551

Files:
  clang-tools-extra/docs/clang-rename.rst
  clang/docs/LibASTImporter.rst
  clang/docs/ReleaseNotes.rst
  clang/docs/analyzer/checkers.rst
  clang/include/clang/AST/OpenMPClause.h
  clang/include/clang/Driver/ToolChain.h
  clang/lib/CodeGen/EHScopeStack.h
  clang/lib/Driver/ToolChain.cpp
  clang/lib/Driver/ToolChains/Cuda.cpp
  clang/lib/Driver/ToolChains/Darwin.cpp
  clang/lib/Driver/ToolChains/HIP.cpp
  libc/CMakeLists.txt
  libc/config/linux/api.td
  libc/lib/CMakeLists.txt
  libc/spec/stdc.td
  libc/src/signal/linux/CMakeLists.txt
  libc/src/signal/linux/signal.cpp
  libc/src/signal/signal.h
  libc/test/src/signal/CMakeLists.txt
  libc/test/src/signal/signal_test.cpp
  libc/utils/UnitTest/Test.cpp
  libc/utils/UnitTest/Test.h
  libcxx/docs/TestingLibcxx.rst
  libcxx/docs/UsingLibcxx.rst
  libcxx/docs/index.rst
  libunwind/docs/BuildingLibunwind.rst
  libunwind/docs/index.rst
  lld/docs/AtomLLD.rst
  lld/docs/NewLLD.rst
  lld/docs/design.rst
  lld/docs/development.rst
  lld/docs/getting_started.rst
  lld/docs/index.rst
  llvm/docs/AMDGPUUsage.rst
  llvm/docs/AliasAnalysis.rst
  llvm/docs/CMake.rst
  llvm/docs/CommandGuide/llvm-lipo.rst
  llvm/docs/CommandGuide/llvm-objcopy.rst
  llvm/docs/CommandGuide/llvm-objdump.rst
  llvm/docs/CommandGuide/llvm-size.rst
  llvm/docs/CommandGuide/llvm-strings.rst
  llvm/docs/CommandGuide/llvm-strip.rst
  llvm/docs/CompileCudaWithLLVM.rst
  llvm/docs/Docker.rst
  llvm/docs/FAQ.rst
  llvm/docs/Frontend/PerformanceTips.rst
  llvm/docs/GettingStarted.rst
  llvm/docs/GettingStartedVS.rst
  llvm/docs/GlobalISel/GMIR.rst
  llvm/docs/GlobalISel/IRTranslator.rst
  llvm/docs/GlobalISel/KnownBits.rst
  llvm/docs/HistoricalNotes/2007-OriginalClangReadme.txt
  llvm/docs/HowToCrossCompileLLVM.rst
  llvm/docs/HowToSetUpLLVMStyleRTTI.rst
  llvm/docs/HowToSubmitABug.rst
  llvm/docs/LLVMBuild.txt
  llvm/docs/LangRef.rst
  llvm/docs/Lexicon.rst
  llvm/docs/LibFuzzer.rst
  llvm/docs/LoopTerminology.rst
  llvm/docs/MarkdownQuickstartTemplate.md
  llvm/docs/MergeFunctions.rst
  llvm/docs/Packaging.rst
  llvm/docs/ProgrammersManual.rst
  llvm/docs/Proposals/GitHubMove.rst
  llvm/docs/README.txt
  llvm/docs/Reference.rst
  llvm/docs/ReleaseProcess.rst
  llvm/docs/SphinxQuickstartTemplate.rst
  llvm/docs/TableGen/index.rst
  llvm/docs/TestSuiteGuide.md
  llvm/docs/TestingGuide.rst
  llvm/docs/TypeMetadata.rst
  llvm/docs/UserGuides.rst
  llvm/docs/Vectorizers.rst
  llvm/docs/WritingAnLLVMPass.rst
  llvm/docs/index.rst
  llvm/docs/tutorial/BuildingAJIT1.rst
  llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl02.rst
  llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl03.rst
  llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl04.rst
  llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl05.rst
  llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl08.rst
  llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl09.rst
  llvm/docs/tutorial/OCamlLangImpl3.rst
  llvm/docs/tutorial/OCamlLangImpl5.rst
  llvm/docs/tutorial/index.rst
  llvm/include/llvm/ADT/Triple.h
  llvm/include/llvm/ExecutionEngine/Orc/Core.h
  llvm/include/llvm/ExecutionEngine/Orc/DebugUtils.h
  llvm/include/llvm/ExecutionEngine/Orc/Speculation.h
  llvm/include/llvm/MC/MCObjectFileInfo.h
  llvm/include/llvm/Target/TargetLoweringObjectFile.h
  llvm/include/llvm/TextAPI/MachO/InterfaceFile.h
  llvm/include/llvm/Transforms/IPO/PassManagerBuilder.h
  llvm/include/llvm/Transforms/InstCombine/InstCombine.h
  llvm/include/llvm/Transforms/Utils/LowerMemIntrinsics.h
  llvm/lib/Analysis/LazyValueInfo.cpp
  llvm/lib/Analysis/TargetLibraryInfo.cpp
  llvm/lib/Analysis/ValueTracking.cpp
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
  llvm/lib/CodeGen/MachineFunction.cpp
  llvm/lib/CodeGen/PrologEpilogInserter.cpp
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/DebugInfo/CodeView/TypeStreamMerger.cpp
  llvm/lib/ExecutionEngine/Orc/Core.cpp
  llvm/lib/ExecutionEngine/Orc/DebugUtils.cpp
  llvm/lib/ExecutionEngine/Orc/Layer.cpp
  llvm/lib/ExecutionEngine/Orc/MachOPlatform.cpp
  llvm/lib/IR/Verifier.cpp
  llvm/lib/Target/AVR/AVRFrameLowering.cpp
  llvm/lib/Target/MSP430/MSP430FrameLowering.cpp
  llvm/lib/Target/Mips/AsmParser/MipsAsmParser.cpp
  llvm/lib/Target/Mips/MCTargetDesc/MipsTargetStreamer.cpp
  llvm/lib/Target/Mips/Mips64InstrInfo.td
  llvm/lib/Target/Mips/MipsCallLowering.cpp
  llvm/lib/Target/Mips/MipsInstrFPU.td
  llvm/lib/Target/Mips/MipsInstrInfo.td
  llvm/lib/Target/Mips/MipsScheduleP5600.td
  llvm/lib/Target/Mips/MipsSubtarget.h
  llvm/lib/Target/Mips/MipsTargetStreamer.h
  llvm/lib/Target/NVPTX/NVPTXLowerAggrCopies.cpp
  llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp
  llvm/lib/Target/RISCV/RISCVFrameLowering.cpp
  llvm/lib/Target/TargetLoweringObjectFile.cpp
  llvm/lib/Target/X86/X86CallFrameOptimization.cpp
  llvm/lib/Target/X86/X86FastISel.cpp
  llvm/lib/Target/X86/X86FrameLowering.cpp
  llvm/lib/Target/X86/X86ISelLowering.cpp
  llvm/lib/Target/X86/X86InstrInfo.cpp
  llvm/lib/Target/X86/X86InstrInfo.h
  llvm/lib/Target/X86/X86TargetObjectFile.cpp
  llvm/lib/Target/X86/X86TargetObjectFile.h
  llvm/lib/Target/X86/X86TargetTransformInfo.cpp
  llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
  llvm/lib/Transforms/InstCombine/InstCombineInternal.h
  llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
  llvm/lib/Transforms/Utils/LowerMemIntrinsics.cpp
  llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
  llvm/test/Analysis/CostModel/X86/reduce-add.ll
  llvm/test/Analysis/CostModel/X86/reduce-and.ll
  llvm/test/Analysis/CostModel/X86/reduce-mul.ll
  llvm/test/Analysis/CostModel/X86/reduce-or.ll
  llvm/test/Analysis/CostModel/X86/reduce-xor.ll
  llvm/test/Analysis/CostModel/X86/reduction.ll
  llvm/test/Analysis/ValueTracking/known-bits-from-operator-constexpr.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-unmerge-values.mir
  llvm/test/CodeGen/AMDGPU/fma-combine.ll
  llvm/test/CodeGen/AMDGPU/mad-combine.ll
  llvm/test/CodeGen/PowerPC/fma-assoc.ll
  llvm/test/CodeGen/PowerPC/fma-negate.ll
  llvm/test/CodeGen/Thumb/frame-access.ll
  llvm/test/CodeGen/Thumb2/LowOverheadLoops/cond-vector-reduce-mve-codegen.ll
  llvm/test/CodeGen/Thumb2/LowOverheadLoops/extending-loads.ll
  llvm/test/CodeGen/Thumb2/mve-postinc-lsr.ll
  llvm/test/CodeGen/X86/avg.ll
  llvm/test/CodeGen/X86/sad.ll
  llvm/test/ExecutionEngine/OrcMCJIT/test-global-ctors.ll
  llvm/test/MC/Mips/cpadd-bad.s
  llvm/test/MC/Mips/cpadd.s
  llvm/test/MC/Mips/macro-sle.s
  llvm/test/MC/Mips/macro-sle64.s
  llvm/test/MC/Mips/macro-sne.s
  llvm/test/Transforms/InstCombine/all-bits-shift.ll
  llvm/test/Transforms/InstCombine/assume.ll
  llvm/test/Transforms/InstCombine/call-returned.ll
  llvm/test/Transforms/InstCombine/expensive-combines.ll
  llvm/test/Transforms/InstCombine/known-bits.ll
  llvm/test/Transforms/InstCombine/known-signbit-shift.ll
  llvm/test/Transforms/InstCombine/out-of-bounds-indexes.ll
  llvm/test/Transforms/InstCombine/phi-shifts.ll
  llvm/test/Transforms/InstCombine/pr44541.ll
  llvm/test/Transforms/InstSimplify/freeze.ll
  llvm/test/Transforms/SCCP/apint-xor.ll
  llvm/test/Transforms/SCCP/conditions-iter-order.ll
  llvm/test/Transforms/SCCP/conditions-ranges.ll
  llvm/test/Transforms/SLPVectorizer/X86/reduction_unrolled.ll
  llvm/test/Verifier/bswap.ll
  llvm/test/tools/llvm-objdump/ELF/PowerPC/branch-offset.s
  llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp
  mlir/docs/LangRef.md
  mlir/include/mlir/Analysis/Passes.h
  mlir/include/mlir/Dialect/Affine/Passes.h
  mlir/include/mlir/IR/StandardTypes.h
  mlir/include/mlir/InitAllPasses.h
  mlir/include/mlir/Transforms/Passes.h
  mlir/lib/Conversion/GPUToCUDA/ConvertKernelFuncToCubin.cpp
  mlir/lib/Conversion/LoopToStandard/CMakeLists.txt
  mlir/lib/Conversion/LoopToStandard/ConvertLoopToStandard.cpp
  mlir/lib/Conversion/LoopToStandard/LoopToStandard.cpp
  mlir/lib/Conversion/LoopsToGPU/LoopsToGPUPass.cpp
  mlir/lib/Conversion/StandardToLLVM/CMakeLists.txt
  mlir/lib/Conversion/StandardToLLVM/ConvertStandardToLLVM.cpp
  mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
  mlir/lib/Dialect/Affine/Transforms/AffineLoopInvariantCodeMotion.cpp
  mlir/lib/Dialect/Affine/Transforms/CMakeLists.txt
  mlir/lib/Dialect/Affine/Transforms/LoopTiling.cpp
  mlir/lib/Dialect/Affine/Transforms/LoopUnroll.cpp
  mlir/lib/Dialect/Affine/Transforms/LoopUnrollAndJam.cpp
  mlir/lib/Dialect/Affine/Transforms/SuperVectorize.cpp
  mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp
  mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp
  mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp
  mlir/lib/Support/MlirOptMain.cpp
  mlir/lib/Transforms/CMakeLists.txt
  mlir/lib/Transforms/LoopTiling.cpp
  mlir/lib/Transforms/LoopUnroll.cpp
  mlir/lib/Transforms/LoopUnrollAndJam.cpp
  mlir/lib/Transforms/Vectorize.cpp
  mlir/test/Conversion/LoopsToGPU/imperfect_2D.mlir
  mlir/test/Conversion/LoopsToGPU/imperfect_3D.mlir
  mlir/test/Conversion/LoopsToGPU/imperfect_4D.mlir
  mlir/test/Conversion/LoopsToGPU/imperfect_linalg.mlir
  mlir/test/Conversion/LoopsToGPU/no_blocks_no_threads.mlir
  mlir/test/Conversion/LoopsToGPU/perfect_1D_setlaunch.mlir
  mlir/test/Conversion/LoopsToGPU/step_one.mlir
  mlir/test/Conversion/LoopsToGPU/step_positive.mlir
  mlir/test/Dialect/Affine/SuperVectorize/compose_maps.mlir
  mlir/test/Dialect/Affine/SuperVectorize/normalize_maps.mlir
  mlir/test/Dialect/Affine/SuperVectorize/vector_utils.mlir
  mlir/test/Dialect/Affine/SuperVectorize/vectorize_1d.mlir
  mlir/test/Dialect/Affine/SuperVectorize/vectorize_2d.mlir
  mlir/test/Dialect/Affine/SuperVectorize/vectorize_3d.mlir
  mlir/test/Dialect/Affine/SuperVectorize/vectorize_outer_loop_2d.mlir
  mlir/test/Dialect/Affine/SuperVectorize/vectorize_outer_loop_transpose_2d.mlir
  mlir/test/Dialect/Affine/SuperVectorize/vectorize_transpose_2d.mlir
  mlir/test/Dialect/Affine/affine-data-copy.mlir
  mlir/test/Dialect/Affine/affine-loop-invariant-code-motion.mlir
  mlir/test/Dialect/Affine/dma-generate.mlir
  mlir/test/Dialect/Affine/loop-tiling.mlir
  mlir/test/Dialect/Affine/parallelism-detection.mlir
  mlir/test/Dialect/Affine/simplify-affine-structures.mlir
  mlir/test/Dialect/Affine/slicing-utils.mlir
  mlir/test/Dialect/Affine/unroll-jam.mlir
  mlir/test/Dialect/Affine/unroll.mlir
  mlir/test/Dialect/Linalg/promote.mlir
  mlir/test/Dialect/Linalg/tile.mlir
  mlir/test/Dialect/Linalg/tile_conv.mlir
  mlir/test/Dialect/Linalg/tile_indexed_generic.mlir
  mlir/test/Dialect/Linalg/tile_parallel.mlir
  mlir/test/Transforms/Vectorize/compose_maps.mlir
  mlir/test/Transforms/Vectorize/normalize_maps.mlir
  mlir/test/Transforms/Vectorize/vector_utils.mlir
  mlir/test/Transforms/Vectorize/vectorize_1d.mlir
  mlir/test/Transforms/Vectorize/vectorize_2d.mlir
  mlir/test/Transforms/Vectorize/vectorize_3d.mlir
  (28 more files...)