[Openmp-commits] [PATCH] D77005: [OpenMP] Optimized stream selection by scheduling data mapping for the same target region into a same stream

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Mar 30 08:03:29 PDT 2020

tianshilei1992 added inline comments.

Comment at: openmp/libomptarget/include/omptarget.h:119
 #ifdef __cplusplus
lildmh wrote:
> Do you need a clang patch to generate code for this structure and new APIs?
Currently no. But of course this information can be used by Clang in the future if needed.

Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:909
+  // If there is no any information, just return
+  if (!async_info->Identifier) {
+    return OFFLOAD_SUCCESS;
lildmh wrote:
> It seems no synchronization by default, not aligned with the original behavior
The assumption here is: if this function is called at the end of `target` function, `Identifier` must be a valid pointer because anyhow during kernel launch it is assigned with a valid `CUstream`.

  rG LLVM Github Monorepo



More information about the Openmp-commits mailing list