[Openmp-commits] [PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version
Kelvin Li via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Sat Mar 14 08:33:43 PDT 2020
kkwli0 added a comment.
In D75001#1922789 <https://reviews.llvm.org/D75001#1922789>, @jdoerfert wrote:
> In D75001#1891284 <https://reviews.llvm.org/D75001#1891284>, @Hahnfeld wrote:
> > In D75001#1887876 <https://reviews.llvm.org/D75001#1887876>, @jdoerfert wrote:
> > > I like this way better. I was hoping we could do it in our cmake only :)
> > >
> > > Give others a day or so to comment before your commit but I'm fine with this.
> > Well, that doesn't really work if `openmp-commits` is only subscribed on commit. That said, the solution is a bit ugly but I don't have an alternative right now.
> What is the problem with `openmp-commits` here? I got the emails, didn't you?
> @kkwli0 Where are we with this?
@jdoerfert In terms of the scope of this issue, it is done. It is to ignore the warning in order to avoid build blockage in the future when newer CUDA toolkit is available and installed on the build system. Another related issue that blocked the other part of the tests (related to python binding) was resolved in https://reviews.llvm.org/D76030. As far as I know, the remaining one (not quite an issue, it is by design) is warning issued when -fopenm-targets=nvptx* is specified, users can suppress it.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the Openmp-commits