[Openmp-commits] [PATCH] D80649: [OpenMP] Improve D2D memcpy to use more efficient driver API

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 marked an inline comment as done.
tianshilei1992 added a comment.

In D80649#2172381 <https://reviews.llvm.org/D80649#2172381>, @protze.joachim wrote:

> I'm looking through the tests in this directory and try to run them on a GPU.
>
> Are those tests supposed to run on GPU?


This patch was to add an interface and only implemented NVIDIA part for now. Other target devices can implement the interface if they support similar thing.



================
Comment at: openmp/libomptarget/test/offloading/d2d_memcpy.c:24-26
+  int dst_device = 1;
+  if (dst_device >= num_devices)
+    dst_device = num_devices - 1;
----------------
protze.joachim wrote:
> What is this supposed to do? 
> I guess you intended to use a different condition in the if, right?
> 
> Why not unconditionally set the dst_device to num_devices-1?
Yeah, that would be better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80649/new/

https://reviews.llvm.org/D80649