[Openmp-commits] [PATCH] D80649: [OpenMP] Improve D2D memcpy to use more efficient driver API

Joachim Protze via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Jul 24 08:30:24 PDT 2020


protze.joachim added a comment.

I'm looking through the tests in this directory and try to run them on a GPU.

Are those tests supposed to run on GPU?



================
Comment at: openmp/libomptarget/test/offloading/d2d_memcpy.c:24-26
+  int dst_device = 1;
+  if (dst_device >= num_devices)
+    dst_device = num_devices - 1;
----------------
What is this supposed to do? 
I guess you intended to use a different condition in the if, right?

Why not unconditionally set the dst_device to num_devices-1?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80649/new/

https://reviews.llvm.org/D80649





More information about the Openmp-commits mailing list