[Openmp-commits] [PATCH] D73249: [openmp] Disable archer if LIBOMP_OMPT_SUPPORT is off

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

In D73249#1835551 <https://reviews.llvm.org/D73249#1835551>, @mgorny wrote:

> In D73249#1835526 <https://reviews.llvm.org/D73249#1835526>, @Hahnfeld wrote:
>
> > I'm not sure `LIBOMP_OMPT_SUPPORT` is guaranteed to be there yet when defined in `runtime/`.
>
>
> If by 'guaranteed' you mean in the current code, then I've tested this patch with it being both true and false.


Ok, as long as it works for the release (that's probably the motivation?) I'm fine with this.

> 
> 
>> Maybe it would be better to move the option to the top-level `openmp/CMakeList.txt` and rename it to `OPENMP_OMPT_SUPPORT` (with compatibility support for `LIBOMP_OMPT_SUPPORT`)
> 
> I don't see a problem moving it. However, I'm not sure if rename is really desired. After all, AFAIU it's a characteristic of the library.

Currently yes, but OMPT callbacks might also be added to libomptarget. We'll need to move then at the latest, but I agree that it might be out-of-scope for this patch (I was just thinking for solutions if `LIBOMP_OMPT_SUPPORT` did not work here).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73249/new/

https://reviews.llvm.org/D73249