[Openmp-commits] [PATCH] D73076: [libomptarget] Implement hip atomic functions in terms of intrinsics

[Matt Arsenault via Phabricator via Openmp-commits]

arsenm added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/atomic_inc.ll:15
+  i32 2, ; Scope. SyncScope.h:  OpenCLAllSVMDevices is 2
+  i1 1 ; Volatile.  True for consistency with other atomic operations
+  )
----------------
This should be false. Where are you seeing this imply volatile? I think we started hacking around OpenCL volatile for atomics in device-libs


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73076/new/

https://reviews.llvm.org/D73076