[Openmp-commits] [PATCH] D73077: [libomptarget] Implement wavefront functions for amdgcn

[Matt Arsenault via Phabricator via Openmp-commits]

arsenm added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.hip:21-22
+
+// initialized with a 64-bit mask with bits set in positions less than the
+// thread's lane number in the warp
+DEVICE __kmpc_impl_lanemask_t __kmpc_impl_lanemask_lt() {
----------------
What about wave32?


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.hip:34
+  uint32_t lane = getLaneId();
+  if (lane == 63)
+    return 0;
----------------
Wave32? WAVESIZE - 1?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73077/new/

https://reviews.llvm.org/D73077