[Openmp-commits] [PATCH] D72779: [OpenMP][Tool] Fix memory leak and double-allocation
Joachim Protze via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Thu Jan 16 12:09:06 PST 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rG39f746d8def6: [OpenMP][Tool] Fix memory leak and double-allocation (authored by protze.joachim).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72779/new/
https://reviews.llvm.org/D72779
Files:
openmp/tools/archer/ompt-tsan.cpp
Index: openmp/tools/archer/ompt-tsan.cpp
===================================================================
--- openmp/tools/archer/ompt-tsan.cpp
+++ openmp/tools/archer/ompt-tsan.cpp
@@ -114,7 +114,6 @@
}
#endif
ArcherFlags *archer_flags;
-TsanFlags *tsan_flags;
// The following definitions are pasted from "llvm/Support/Compiler.h" to allow
// the code
@@ -862,10 +861,8 @@
static int ompt_tsan_initialize(ompt_function_lookup_t lookup,
int device_num,
ompt_data_t *tool_data) {
- const char *options = getenv("ARCHER_OPTIONS");
- archer_flags = new ArcherFlags(options);
- options = getenv("TSAN_OPTIONS");
- tsan_flags = new TsanFlags(options);
+ const char *options = getenv("TSAN_OPTIONS");
+ TsanFlags tsan_flags(options);
ompt_set_callback_t ompt_set_callback =
(ompt_set_callback_t)lookup("ompt_set_callback");
@@ -898,7 +895,7 @@
SET_CALLBACK_T(mutex_released, mutex);
SET_OPTIONAL_CALLBACK_T(reduction, sync_region, hasReductionCallback, ompt_set_never);
- if (!tsan_flags->ignore_noninstrumented_modules)
+ if (!tsan_flags.ignore_noninstrumented_modules)
fprintf(
stderr,
"Warning: please export TSAN_OPTIONS='ignore_noninstrumented_modules=1' "
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72779.238571.patch
Type: text/x-patch
Size: 1285 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20200116/30719806/attachment.bin>
More information about the Openmp-commits
mailing list