[Openmp-commits] [PATCH] D72779: [OpenMP][Tool] Fix memory leak and double-allocation

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Jan 15 10:03:14 PST 2020


Hahnfeld added inline comments.


================
Comment at: openmp/tools/archer/ompt-tsan.cpp:866
+  const char *options = getenv("TSAN_OPTIONS");
   tsan_flags = new TsanFlags(options);
 
----------------
Why do we need `tsan_flags` globally? It's again deleted further below, you can just put it onto the stack.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72779/new/

https://reviews.llvm.org/D72779





More information about the Openmp-commits mailing list