[Openmp-commits] [PATCH] D70412: [OpenMP][Tool] Runtime warning for missing TSan-option

Wed Jan 15 02:28:37 PST 2020

jdoerfert added a comment.

In D70412#1821136 <https://reviews.llvm.org/D70412#1821136>, @protze.joachim wrote:

> In D70412#1820406 <https://reviews.llvm.org/D70412#1820406>, @Hahnfeld wrote:
>
> > This revision was not accepted before being committed!
>
>
> It was a misunderstanding on my side. Johannes told me that he is fine with the changes before I pushed. I didn't check that the accepted flag was not on the patch.
>  What procedure do you suggest?

I did say I was generally fine with this but it should not trigger if we build the runtime with tsan instrumentation.
That, and especially the memory leak @Hahnfeld found, need to be taken care of ASAP.

Also, when was the CREDITS.txt change added?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70412/new/

https://reviews.llvm.org/D70412