[Openmp-commits] [PATCH] D93055: [OpenMP] Add time profiling for libomptarget

[Alexander Yermolovich via Phabricator via Openmp-commits]

ayermolo added a comment.

In D93055#2461829 <https://reviews.llvm.org/D93055#2461829>, @JonChesterfield wrote:

> Ah, yes. That makes sense. Building llvmsupport without PIC is a reasonable thing to do, and will cause problems when linked into libomptarget. One solution is to link libomptarget against a dynamically built llvmsupport, which might mean building llvmsupport twice. I don't know whether the existing cmake is wired up to do that.
>
> I'd prefer we default to profiling disabled (and the llvm libs not linked in) for now.
>
> (actually my preferred solution is to link libomptarget statically, but that feels like a longer term goal)

I would prefer that also. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93055/new/

https://reviews.llvm.org/D93055