[Openmp-commits] [PATCH] D92942: Handle implicit conversion warnings

[Terry Wilmarth via Phabricator via Openmp-commits]

tlwilmar created this revision.
tlwilmar added reviewers: AndreyChurbanov, hbae.
tlwilmar added a project: OpenMP.
Herald added a subscriber: mgorny.
tlwilmar requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.

This patch partially prepares the runtime source code to be built with -Wconversion, which should trigger warnings if any implicit conversions can possibly change a value. For builds done with icc or gcc, all such warnings are handled in this patch. clang gives a much longer list of warnings, particularly for sign conversions, which the other compilers don't report. The -Wconversion flag is commented into cmake files, but I'm not going to turn it on. If someone thinks it is important, and wants to fix all the clang warnings, they are welcome to.

Types of changes made here involve either improving the consistency of types used so that no conversion is needed, or else performing careful explicit conversions, when we're sure a problem won't arise.

Patch is a combination of changes by Terry Wilmarth and Johnny Peyton.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D92942

Files:
  openmp/runtime/cmake/LibompHandleFlags.cmake
  openmp/runtime/cmake/config-ix.cmake
  openmp/runtime/src/kmp.h
  openmp/runtime/src/kmp_affinity.cpp
  openmp/runtime/src/kmp_affinity.h
  openmp/runtime/src/kmp_alloc.cpp
  openmp/runtime/src/kmp_atomic.cpp
  openmp/runtime/src/kmp_barrier.cpp
  openmp/runtime/src/kmp_csupport.cpp
  openmp/runtime/src/kmp_dispatch.cpp
  openmp/runtime/src/kmp_dispatch_hier.h
  openmp/runtime/src/kmp_environment.cpp
  openmp/runtime/src/kmp_ftn_entry.h
  openmp/runtime/src/kmp_gsupport.cpp
  openmp/runtime/src/kmp_i18n.h
  openmp/runtime/src/kmp_itt.inl
  openmp/runtime/src/kmp_lock.cpp
  openmp/runtime/src/kmp_runtime.cpp
  openmp/runtime/src/kmp_settings.cpp
  openmp/runtime/src/kmp_stats.cpp
  openmp/runtime/src/kmp_stats.h
  openmp/runtime/src/kmp_str.cpp
  openmp/runtime/src/kmp_str.h
  openmp/runtime/src/kmp_stub.cpp
  openmp/runtime/src/kmp_stub.h
  openmp/runtime/src/kmp_taskdeps.cpp
  openmp/runtime/src/kmp_tasking.cpp
  openmp/runtime/src/kmp_threadprivate.cpp
  openmp/runtime/src/kmp_utility.cpp
  openmp/runtime/src/kmp_wait_release.h
  openmp/runtime/src/ompt-specific.cpp
  openmp/runtime/src/z_Linux_util.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92942.310554.patch
Type: text/x-patch
Size: 58930 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20201209/bfc5160c/attachment-0001.bin>