[Openmp-commits] [PATCH] D92604: [OpenMP] Introduce new file wrapper class for runtime

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

Really nice cleanup. My only request is more documentation for new code.



================
Comment at: openmp/runtime/src/kmp.h:4066
+  operator FILE *() { return f; }
+};
+
----------------
Please include doxygen documentation, at least for non trivial methods and the class. Maybe use "RAII" in the class name to indicate the functionality and make it clear there is no "close" needed at use sites.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92604/new/

https://reviews.llvm.org/D92604