[Openmp-commits] [PATCH] D77609: [OpenMP][WIP] Added the support for unshackled task in RTL

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added a comment.

In D77609#2236303 <https://reviews.llvm.org/D77609#2236303>, @adurang wrote:

> As a more general comment creating that many threads upfront even they're not necessary seems like a problematic thing (e.g., potential performance problems, tools confusion, ... ). Can we not delay the creation of the team to moment where is first necessary (i.e., at the first //target nowait region//?) This is a general principle followed through the RTL so far (whith sometimes an optional env var to advance that initialization).

I don't understand. There is no need to create the unshackled team if no unshackled task is encountered. Even in current RTL, the team is created on demand.

> Also, any plans on how this feature will be supported on Windows?

I didn't have plan to support Windows, especially considering the fact that offloading has not been supported on Windows yet.

> Last, are there any unit tests for this feature? I don't see any in the patch.

I will definitely add tests.

Thanks for the comments!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77609/new/

https://reviews.llvm.org/D77609