[Openmp-commits] [openmp] f93b42a - [NFC][OpenMP] Remove outdated comments about potential issues

Shilei Tian via Openmp-commits openmp-commits at lists.llvm.org
Sun Aug 23 18:24:05 PDT 2020


Author: Shilei Tian
Date: 2020-08-24T01:21:06Z
New Revision: f93b42a629ae5865bf71f8062553125b8684deaf

URL: https://github.com/llvm/llvm-project/commit/f93b42a629ae5865bf71f8062553125b8684deaf
DIFF: https://github.com/llvm/llvm-project/commit/f93b42a629ae5865bf71f8062553125b8684deaf.diff

LOG: [NFC][OpenMP] Remove outdated comments about potential issues

The issue mentioned has been fixed in D84996

Added: 
    

Modified: 
    openmp/libomptarget/src/omptarget.cpp

Removed: 
    


################################################################################
diff  --git a/openmp/libomptarget/src/omptarget.cpp b/openmp/libomptarget/src/omptarget.cpp
index aa4ab75573b4..bc9287f0b4e1 100644
--- a/openmp/libomptarget/src/omptarget.cpp
+++ b/openmp/libomptarget/src/omptarget.cpp
@@ -953,8 +953,6 @@ int processDataBefore(int64_t DeviceId, void *HostPtr, int32_t ArgNum,
 
 /// Process data after launching the kernel, including transferring data back to
 /// host if needed and deallocating target memory of (first-)private variables.
-/// FIXME: This function has correctness issue that target memory might be
-/// deallocated when they're being used.
 int processDataAfter(int64_t DeviceId, void *HostPtr, int32_t ArgNum,
                      void **ArgBases, void **Args, int64_t *ArgSizes,
                      int64_t *ArgTypes, void **ArgMappers,


        


More information about the Openmp-commits mailing list