[Openmp-commits] [PATCH] D86307: [OpenMP] Pack first-private arguments to improve efficiency of data transfer

[Ye Luo via Phabricator via Openmp-commits]

ye-luo added a comment.

Only minor things.



================
Comment at: openmp/libomptarget/src/omptarget.cpp:830
+  /// The index of the element in \p TgtArgs corresponding to the argument
+  int Index;
+  /// Host pointer begin
----------------
const?


================
Comment at: openmp/libomptarget/src/omptarget.cpp:836
+  /// Aligned size
+  int64_t AlignedSize;
+
----------------
const?


================
Comment at: openmp/libomptarget/src/omptarget.cpp:1019
   std::vector<ptrdiff_t> TgtOffsets;
-  std::vector<void *> FPArrays;
 
----------------
jdoerfert wrote:
> Why? Still multiple.
> Why? Still multiple.

I think it is a vector of first private arrays. So the name better  to be plural.

FirstPrivateArgs seems to be a better name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86307/new/

https://reviews.llvm.org/D86307