[Openmp-commits] [PATCH] D81054: [OpenMP] Introduce target memory manager

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 marked 3 inline comments as done.
tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/src/device.cpp:419
+
   return RTL->data_delete(RTLDeviceID, TgtPtrBegin);
 }
----------------
ye-luo wrote:
> Prefer
> ```
> else
>   return RTL->data_delete(RTLDeviceID, TgtPtrBegin);
> ```
> the same change to RTL->data_alloc above
It's a code style preference. I would go with "no else after return".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81054/new/

https://reviews.llvm.org/D81054