[Openmp-commits] [PATCH] D81054: [OpenMP] Introduce target memory manager

Tue Aug 18 19:56:13 PDT 2020

tianshilei1992 marked an inline comment as done.
tianshilei1992 added a comment.

In D81054#2225277 <https://reviews.llvm.org/D81054#2225277>, @ye-luo wrote:

> 2. Because the memory limit is per allocation, it seems that the MemoryManager can still hold infinite amount of memory and we don't have  way to free them. I'm concerned about having this feature on by default.

First, users can always opt out the feature. What’s more important, if we receive complaints that this feature causes their applications OOM, we could evaluate it and then make corresponding change. What we know for now is many applications benefit from it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81054/new/

https://reviews.llvm.org/D81054