[Openmp-commits] [PATCH] D85934: Enable OpenMP offloading to VE and enable tests for offloading to VE

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added inline comments.


================
Comment at: openmp/libomptarget/test/lit.cfg:67
     append_dynamic_library_path('DYLD_LIBRARY_PATH', \
         config.omp_host_rtl_directory, ";")
     config.test_flags += " -Wl,-rpath," + config.library_dir
----------------
Unrelated to this patch, but why are different separators used for Darwin?


================
Comment at: openmp/libomptarget/test/lit.cfg:78-83
+if 've-unknown-linux-unknown' in config.libomptarget_system_targets and \
+        config.omp_host_rtl_directory:
+    config.test_flags = config.test_flags + " -Xopenmp-target \"-L" +\
+        config.omp_host_rtl_directory + "\""
+    append_dynamic_library_path('VE_LD_LIBRARY_PATH',
+        config.omp_host_rtl_directory, ":")
----------------
I think, this should only be set for the specific device RUN-lines. I suggest to include the flags and export of the environment variable in the definition of `%libomptarget-compile-ve-unknown-linux-unknown`.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85934/new/

https://reviews.llvm.org/D85934