[Openmp-commits] [PATCH] D85742: [libomptarget] Implement host plugin for amdgpu

[Ron Lieberman via Phabricator via Openmp-commits]

ronlieb added inline comments.


================
Comment at: openmp/libomptarget/plugins/amdgpu/src/rtl.cpp:39-97
+// Get static gpu grid values from clang target-specific constants managed
+// in the header file llvm/Frontend/OpenMP/OMPGridValues.h
+// Copied verbatim to meet the requirement that libomptarget builds without
+// a copy of llvm checked out nearby
+namespace llvm {
+namespace omp {
+enum GVIDX {
----------------
please revisit this inclusion of the file content from llvm/Frontend/OpenMP/OMPGridValues.h

seems like we have a maintenance issue going forward.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85742/new/

https://reviews.llvm.org/D85742