[Openmp-commits] [PATCH] D85742: [libomptarget] Implement host plugin for amdgpu

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

There are some parts of this that I'm hoping to push down into the hsa/rocr layer. And other parts that can be deleted without replacement. I will make this better. Good to have clang dev unblocked in the meantime.



================
Comment at: openmp/libomptarget/plugins/amdgpu/src/rtl.cpp:1004
+  // begin and end as well as the target name (see the offloading linker script
+  // creation in clang compiler).
+
----------------
jdoerfert wrote:
> There is no linker script anymore, IIRC.
Indeed not. And Guansong is no longer with AMD, so may be difficult to check with anyway. Will drop this comment in the near future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85742/new/

https://reviews.llvm.org/D85742