[Openmp-commits] [PATCH] D81054: [OpenMP] Introduce target memory manager

[Ye Luo via Phabricator via Openmp-commits]

ye-luo added inline comments.


================
Comment at: openmp/libomptarget/src/MemoryManager.cpp:107
+  /// Nodes are used in a format of \p std::shared_ptr<Node>
+  using NodePtrTy = std::shared_ptr<NodeTy>;
+
----------------
Another shared_ptr. See `typedef std::set<HostDataToTargetTy, std::less<>> HostDataToTargetListTy;` as an example. There doesn't seem to need a pointer wrapping NodeTy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81054/new/

https://reviews.llvm.org/D81054