[Openmp-commits] [PATCH] D81054: [OpenMP] Introduce target memory manager

Wed Aug 12 10:15:00 PDT 2020

tianshilei1992 added a comment.

In D81054#2213550 <https://reviews.llvm.org/D81054#2213550>, @ye-luo wrote:

> 1. Please mention LIBOMPTARGET_MEMORY_MANAGER_THRESHOLD, default value and unit in the patch summary.

Sure. Will do.

> 2. Is it possible to have a unit test testing the manager class behaviors?

I don't think so. We don't have the "unit test" framework you want. If you insist some tests, I could add a simple "feature" test here.

> 3. Can we offload to host and run address sanitizer or valgrind?

What do you mean by offload to host? This memory manager will not be used by the device.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81054/new/

https://reviews.llvm.org/D81054