[Openmp-commits] [PATCH] D81054: [OpenMP] Introduce target memory manager

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 marked 2 inline comments as done.
tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/src/MemoryManager.h:37
+
+  /// Deallocate memory pointed by \p TgtPtr
+  int free(void *TgtPtr);
----------------
JonChesterfield wrote:
> Deallocate taking a size usually allows a faster implementation, but that can be left until said faster implementation is proposed
I agree. Currently the plugin interface does not have such argument so we don't need that. In the future we might add that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81054/new/

https://reviews.llvm.org/D81054