[Openmp-commits] [PATCH] D84456: [OpenMP] Refactor memory allocation code for easier support for third party memory libraries

Latchesar Ionkov via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Aug 12 07:15:16 PDT 2020

lionkov added a comment.

In D84456#2213019 <https://reviews.llvm.org/D84456#2213019>, @AndreyChurbanov wrote:

> In D84456#2213006 <https://reviews.llvm.org/D84456#2213006>, @lionkov wrote:
>> In D84456#2212180 <https://reviews.llvm.org/D84456#2212180>, @jdoerfert wrote:
>>> In D84456#2212175 <https://reviews.llvm.org/D84456#2212175>, @lionkov wrote:
>>>> Other than few formatting changes the instructions from the link didn't provide any information about "full diff". Is that related to arcanist somehow? I can try to figure out how to use it if that'll help. :)
>>> I figured if I give you the link to the start of "how to submit a patch" you would follow the links from there. My bad: https://llvm.org/docs/Phabricator.html#phabricator-request-review-web
>> That's exactly the instructions I followed to submit my patch. If it is lacking some details, I would like to know how to fix it.
> The key difference is:
> git diff   # gives you short patch
> git diff -U999999  # gives you full patch
> The full patch should have complete source, as opposed to 3 lines above and below the changes for the short patch.

Ugh, sorry I missed that! Fixed.



More information about the Openmp-commits mailing list