[Openmp-commits] [PATCH] D84456: [OpenMP] Refactor memory allocation code for easier support for third party memory libraries

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

I'm the wrong person to review this. @AndreyChurbanov



================
Comment at: openmp/runtime/src/kmp.h:966
+  void (*free)(void *p, kmp_allocator_t *, int gtid);
+  void *aux;
 } kmp_allocator_t;
----------------
What is aux? Could you provide a doxygen style comment for all new members please.


================
Comment at: openmp/runtime/src/kmp_alloc.cpp:1321
+      } else
+        al->fb_data = RCAST(kmp_allocator_t *, traits[i].value);
       break;
----------------
Nit: No braces, or braces for the else.


================
Comment at: openmp/runtime/src/kmp_alloc.cpp:1341
+  al->alloc = kmp_default_alloc; // kmp_standard_allocators[(uintptr_t) ms].alloc;
+  al->free = kmp_default_free; // kmp_standard_allocators[(uintptr_t) ms].free;
+  if (kmp_init_allocator_p != NULL && kmp_init_allocator_p(al) != 0) {
----------------
Are these comments left over or should they explain something?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84456/new/

https://reviews.llvm.org/D84456