[Openmp-commits] [PATCH] D85320: [OpenMP] Fix `present` diagnostic for array extension

Vyacheslav Zakharin via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Aug 5 13:19:26 PDT 2020

vzakhari added inline comments.

Comment at: openmp/libomptarget/src/device.cpp:197
+      MESSAGE("device mapping required by 'present' map type modifier does not "
+              "exist for host address " DPxMOD " (%ld bytes)",
+              DPxPTR(HstPtrBegin), Size);
jdenny wrote:
> grokos wrote:
> > jdenny wrote:
> > > vzakhari wrote:
> > > > Can you please use PRId64 instead?  '%ld' tends to break Windows builds.
> > > Thanks for catching that.  I'll fix this here and propose another patch to fix all the other places I made this mistake.
> > I'm preparing a patch to replace all instances of %ld with PRId64 for int64_t variables throughout libomptarget. There are many more instances than introduced by your patches.
> Thanks.  I'll just fix this one then.
Thank you!



More information about the Openmp-commits mailing list