[Openmp-commits] [PATCH] D77603: [OpenMP] Sync writes to child thread's data before reduction

[Bryan Chan via Phabricator via Openmp-commits]

bryanpkc added a comment.

In D77603#1970402 <https://reviews.llvm.org/D77603#1970402>, @AndreyChurbanov wrote:

> I don't see paired memory barrier in a child thread between assigning th.th_local.reduce_data in __kmp_barrier_template() and releasing b_arrived barrier flag that frees parent to go to reduce data.


Thanks for the review. You are right, the atomic release does not serve as a memory barrier, and I should add a paired memory barrier after the child thread finishes writing to its local data.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77603/new/

https://reviews.llvm.org/D77603