[Openmp-commits] [PATCH] D77603: [OpenMP] Sync writes to child thread's data before reduction

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov added a comment.

I don't see paired memory barrier in a child thread between assigning th.th_local.reduce_data in __kmp_barrier_template() and releasing b_arrived barrier flag that frees parent to go to reduce data.   So it might be that the problem could just become lesser probable.  Should paired KMP_MB be added after the reduce_data assignment?   Or does atomic releasing of a flag serves as a memory barrier?  Then my assumption is wrong and second MB is not needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77603/new/

https://reviews.llvm.org/D77603