[Openmp-commits] [PATCH] D76843: [Openmp] Libomptarget plugin for NEC SX-Aurora

[Simon Moll via Phabricator via Openmp-commits]

simoll added inline comments.


================
Comment at: openmp/libomptarget/plugins/ve/src/rtl.cpp:298
+      }
+    } else {
+      proc_handle = veo_proc_create_static(ID, tmp_name);
----------------
manorom wrote:
> simoll wrote:
> > else after return
> I don't think so: If the process handle for a dynamic process is created successfully, we do not return but also do not want to visit the else branch.
This is simply a matter of coding style. You can rewrite the `else` to

```
if (!is_dyn) {
}
```

and it is clear under which condition it will be executed.


================
Comment at: openmp/libomptarget/plugins/ve/src/rtl.cpp:336
+    DP("Successfully loaded library dynamically\n");
+  } else {
+    DP("Symbol table is expected to have been created by "
----------------
manorom wrote:
> simoll wrote:
> > else after return
> Same as above: if the library handle is created successfully, there is no return here.
same as above


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76843/new/

https://reviews.llvm.org/D76843