[Openmp-commits] [PATCH] D76843: [Openmp] Libomptarget plugin for NEC SX-Aurora

[Manoel Roemmer via Phabricator via Openmp-commits]

manorom marked 3 inline comments as done.
manorom added inline comments.


================
Comment at: openmp/libomptarget/plugins/ve/src/rtl.cpp:298
+      }
+    } else {
+      proc_handle = veo_proc_create_static(ID, tmp_name);
----------------
simoll wrote:
> else after return
I don't think so: If the process handle for a dynamic process is created successfully, we do not return but also do not want to visit the else branch.


================
Comment at: openmp/libomptarget/plugins/ve/src/rtl.cpp:336
+    DP("Successfully loaded library dynamically\n");
+  } else {
+    DP("Symbol table is expected to have been created by "
----------------
simoll wrote:
> else after return
Same as above: if the library handle is created successfully, there is no return here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76843/new/

https://reviews.llvm.org/D76843