[Openmp-commits] [PATCH] D69652: [nfc][libomptarget] Reorganise support header

Wed Oct 30 22:47:32 PDT 2019

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

There seem to be unrelated moves but other than that this looks good to me. Consider not moving stuff if it's not necessary and also using a different header guard name.

LGTM.

================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/support.h:14
+#ifndef _OMPTARGET_SUPPORT_H_
+#define _OMPTARGET_SUPPORT_H_
+
----------------
The device RTL is not consistent here (__XXX and _XXX are used) and it is different from LLVM. I'd vote for LLVM style, thus `OMPTARGET_SUPPORT_H`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69652/new/

https://reviews.llvm.org/D69652