[Openmp-commits] [PATCH] D69652: [nfc][libomptarget] Reorganise support header

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Oct 30 19:53:31 PDT 2019


JonChesterfield created this revision.
JonChesterfield added reviewers: jdoerfert, ABataev, grokos.
Herald added subscribers: openmp-commits, jfb, mgorny.
Herald added a project: OpenMP.

[nfc][libomptarget] Reorganise support header

All functions defined in support implementation are now declared in support.h
Reordered functions in support implementation to match the sequence in support.h
Added include guards to support.h
Added #include interface to support.h to provide kmp_Ident declaration
Move supporti.h to support.cu and s/INLINE/EXTERN/g
Add remaining includes to support.cu

A minor side effect is to change the name mangling of the support functions to
extern "C". If this matters another macro along the lines of INLINE/EXTERN
can be added - perhaps DEVICE as that's the obvious implementation.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D69652

Files:
  openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt
  openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h
  openmp/libomptarget/deviceRTLs/nvptx/src/support.cu
  openmp/libomptarget/deviceRTLs/nvptx/src/support.h
  openmp/libomptarget/deviceRTLs/nvptx/src/supporti.h
  openmp/libomptarget/deviceRTLs/nvptx/unity.cu

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69652.227213.patch
Type: text/x-patch
Size: 17598 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20191031/441b566a/attachment.bin>


More information about the Openmp-commits mailing list