[Openmp-commits] [PATCH] D68369: Use -1 to indicate all lanes, to handle 32 and 64 wide architectures

Wed Oct 2 19:56:15 PDT 2019

JonChesterfield added a comment.

In D68369#1692354 <https://reviews.llvm.org/D68369#1692354>, @grokos wrote:

> I'm wondering whether it would be better to define `__kmpc_impl_all_lanes` conditionally, i.e. as 0xFFFF for 32-wide and 0xFFFFFFFF for 64-wide architectures. I'm not sure I like this implicit signed-to-unsigned conversion here... Also, `__kmpc_impl_lanemask_t` is currently typedef'ed as `uint32_t`, if we want to support 64-wide lanes, then `__kmpc_impl_lanemask_t` must also be conditionally defined accordingly.

More F's. But sure, I'm happy to define it as UINT32_C(0xffffffff) for nvptx instead.

The 64 lane architecture I'm thinking of has it's own target_impl.h where the corresponding typedef is indeed to uint64_t, and all the functions in this file have different implementations. See https://github.com/ROCm-Developer-Tools/llvm-project/blob/AOMP-190918/openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h if you're curious.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68369/new/

https://reviews.llvm.org/D68369