[Openmp-commits] [PATCH] D68369: Use -1 to indicate all lanes, to handle 32 and 64 wide architectures

[George Rokos via Phabricator via Openmp-commits]

grokos added a comment.

I'm wondering whether it would be better to define `__kmpc_impl_all_lanes` conditionally, i.e. as 0xFFFF for 32-wide and 0xFFFFFFFF for 64-wide architectures. I'm not sure I like this implicit signed-to-unsigned conversion here... Also, `__kmpc_impl_lanemask_t` is currently typedef'ed as `uint32_t`, if we want to support 64-wide lanes, then `__kmpc_impl_lanemask_t` must also be conditionally defined accordingly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68369/new/

https://reviews.llvm.org/D68369