[Openmp-commits] [PATCH] D70414: [libomptarget] Build a minimal deviceRTL for amdgcn

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield marked 2 inline comments as done.
JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt:136
+  )
+endforeach()
----------------
jdoerfert wrote:
> Nit: I'm not a cmake person but I am surprised to see "cuda" above so many times, e.g. in file names?
The source is (currently still) cuda so it's not too bad that variables refer to cuda. I didn't rename anything from Greg's original script. Happy to rename the variables before or after commit.

I'd like to put the remaining cuda intrinsics behind an API and rename the files to .cpp, but the renaming caused problems with nvcc that I am not yet sure how to solve.


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h:114
+EXTERN int32_t __kmpc_impl_shfl_down_sync(__kmpc_impl_lanemask_t, int32_t Var,
+                                          uint32_t Delta, int32_t Width);
 
----------------
jdoerfert wrote:
> Where did these implementations go?
The previous implementation called through to functions in a support library with fairly ugly prototypes.

I'm planning to implement these in target_impl.hip, which doesn't exist yet. Until then they're just another couple of missing symbols.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70414/new/

https://reviews.llvm.org/D70414