[Openmp-commits] [PATCH] D70414: [libomptarget] Build a minimal deviceRTL for amdgcn

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

Thanks for pushing this. Two comments below, nothing major.



================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt:136
+  )
+endforeach()
----------------
Nit: I'm not a cmake person but I am surprised to see "cuda" above so many times, e.g. in file names?


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h:114
+EXTERN int32_t __kmpc_impl_shfl_down_sync(__kmpc_impl_lanemask_t, int32_t Var,
+                                          uint32_t Delta, int32_t Width);
 
----------------
Where did these implementations go?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70414/new/

https://reviews.llvm.org/D70414