[Openmp-commits] [PATCH] D69857: [libomptarget] Replace INLINE with DEVICE to work around nvcc deleting forceinline symbols

Tue Nov 5 17:05:03 PST 2019

ABataev added a comment.

In D69857#1734842 <https://reviews.llvm.org/D69857#1734842>, @JonChesterfield wrote:

> In D69857#1734826 <https://reviews.llvm.org/D69857#1734826>, @ABataev wrote:
>
> > Bad decision. I would suggest to revert your pr3vious patches and restore intial code layout and then try step by step fixing it.
>
>
> Well, we can't leave trunk broken. So sure, feel free to revert them.

It takes too much time, better you to revert them as yoh're much more familiar with the changes you landed.

> However I cannot debug errors which only occur on other developers machines when using closed source compilers. So I can't fix it later either.

I can try them locally and can say if they break something or not before yoj will try to commit them.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69857/new/

https://reviews.llvm.org/D69857